listbox: Avoid using show_all on rows
authorKalev Lember <klember@redhat.com>
Sat, 8 Aug 2015 14:33:42 +0000 (16:33 +0200)
committerKalev Lember <klember@redhat.com>
Sat, 8 Aug 2015 14:54:31 +0000 (16:54 +0200)
Don't use gtk_widget_show_all() on row widgets because that would
unconditionally show all of its children. This might be unwanted in case
the row implementation wants to keep some of its children hidden.

This commit changes it to use show() instead of show_all() and relies on
the row widget to control the visibility of its children itself as
appropriate.

https://bugzilla.gnome.org/show_bug.cgi?id=753392

gtk/gtklistbox.c

index e6846d2d702979e5246c3ab7878dd52041899a90..9de26ca91485b682850b3a3afc39556e1d2c6a50 100644 (file)
@@ -3684,7 +3684,7 @@ gtk_list_box_bound_model_changed (GListModel *list,
       if (g_object_is_floating (widget))
         g_object_ref_sink (widget);
 
-      gtk_widget_show_all (widget);
+      gtk_widget_show (widget);
       gtk_list_box_insert (box, widget, position + i);
 
       g_object_unref (widget);